Skip to content

Tweaks to .mill file codegen #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2025
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Mar 29, 2025

Small adjustments to bring them into line with vanilla .scala file semantics, and other cleanups, backported from #4745

@lihaoyi lihaoyi marked this pull request as ready for review March 29, 2025 19:16
@lihaoyi lihaoyi merged commit 460546a into com-lihaoyi:main Mar 30, 2025
32 of 33 checks passed
@lefou lefou added this to the 0.13.0 milestone Mar 30, 2025
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch file looks strange. It's base looks outdated, it's target seems to contain more that just compat stuff.

@lefou
Copy link
Member

lefou commented Mar 30, 2025

Nevermind, I missread the the diff of the diff.

lefou pushed a commit to lefou/mill that referenced this pull request Mar 30, 2025
Small adjustments to bring them into line with vanilla `.scala` file
semantics, and other cleanups, backported from
com-lihaoyi#4745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants