Add examples of mill + cask + scalasql #4924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyawaikar
changed the title
lihaoyi
reviewed
Apr 16, 2025
| @@ -0,0 +1,265 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
Shouldn't need the mill file in the examples, it gets filled in automatically when publishing
lihaoyi
reviewed
Apr 16, 2025
| ivy"com.h2database:h2:2.2.224" | ||
| ) | ||
|
|
||
| object test extends ScalaTests { |
There was a problem hiding this comment.
Let's have one test suite using H2 in memory and one integration suite using PostgreSQL via testcontainers.
|
@chaitanyawaikar left some comments but otherwise looks reasonable |
"[6549-0] [error] -- [E8] /home/runner/work/mill/mill/out/example/scalalib/web/11-todo-http4s-scalasql/native/server/testForked.dest/worker-0/sandbox/run-2/build.mill:7:5 [6549-0] [error] 7 ? ivy"org.http4s::http4s-ember-server::0.23.30", [6549-0] [error] ? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [6549-0] [error] ?value ivy is not a member of StringContext, but could be made available as an extension method. [6549-0] [error] ? [6549-0] [error] ?One of the following imports might fix the problem: [6549-0] [error] ? [6549-0] [error] ? import coursier.ivyRepositoryString [6549-0] [error] ? import coursier.util.StringInterpolators.SafeIvyRepository [6549-0] [error] ? [6549-0] [error] ? [6549-0] [error] -- [E8] /home/runner/work/mill/mill/out/example/scalalib/web/11-todo-http4s-scalasql/native/server/testForked.dest/worker-0/sandbox/run-2/build.mill:8:5"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue #4799. It includes creation of two new examples of the very popular TODO MVC app
10-todo-webapp-cask-scalasql11-todo-http4s-scalasqlUnit tests and a short documentation have been added for each of these modules.
@lihaoyi Once the approach/implementation looks fine, I can proceed to adding the integration tests.