Send BSP onBuildTargetDidChange notifications to clients when the build changes #4957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meant to be shared between BSP integration tests
So that they're not removed while the evaluator uses them
lefou
reviewed
Apr 18, 2025
|
|
||
| def initialized = sessionInfo != null | ||
|
|
||
| def updateEvaluator(evaluatorsOpt: Option[Seq[EvaluatorApi]]): Unit = { | ||
| def updateEvaluator(evaluatorsOpt: Option[Seq[EvaluatorApi]], errored: Boolean): Unit = { |
There was a problem hiding this comment.
Can we have ScalaDoc explaining what error means.
| @@ -45,21 +45,98 @@ private class MillBuildServer( | |||
| // progresses through: | |||
| // | |||
| // Set when the client connects | |||
| protected var client: BuildClient = scala.compiletime.uninitialized | |||
| protected var client: BuildClient = null | |||
There was a problem hiding this comment.
Why is uninitialized not enough? Can we use a better type then, e.g. Option?
|
I haven't looked at the code in detail since it hasn't been cleaned up yet, but one thing we should do is try to re-use as much logic as possible from the normal |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Mil send onBuildTargetDidChange BSP notifications to clients when the build change. If ever the build compilation fails at some point, this tries to keep the former evaluators of build levels that can't be loaded anymore, so that there's less interruption of IDE features for end users (that is, if
build.millis broken, this keeps using an old evaluator for the main build tasks, same for the first meta-build and the main build ifmill-build/build.millis broken, etc.).In order for the preserved evaluators to keep working, but also to help with concurrency, this makes
MillBuildBootstrapcopy meta-builds' classes to a temporary directory right before loading them in a class loader, so that concurrent sessions don't remove class files that we need.Lastly, when
--bspis passed, this makes sure we don't print messages for users in it early on, only BSP messages.