Skip to content

Draft: Implement watching file paths via oslib.watch (for 0.12.x branch) #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: 0.12.x
Choose a base branch
from

Conversation

arturaz
Copy link
Contributor

@arturaz arturaz commented May 6, 2025

Backport of #5068

The fs watching is disabled by default and can be disabled via --watch-via-fs-notify=true.

@arturaz arturaz changed the base branch from main to 0.12.x May 6, 2025 09:26
@arturaz arturaz force-pushed the improvement/fs-watching-0.12.x branch from 25e1fb5 to caffff7 Compare May 8, 2025 09:40
@arturaz arturaz force-pushed the improvement/fs-watching-0.12.x branch from 7c1395f to 063e47f Compare May 8, 2025 09:53
@arturaz
Copy link
Contributor Author

arturaz commented May 8, 2025

Noticed this popping up while testing (note for self):

Exception in thread "Thread-535" java.nio.channels.ClosedChannelException
        at java.base/sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:160)
        at java.base/sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:284)
        at java.base/sun.nio.ch.ChannelOutputStream.writeFully(ChannelOutputStream.java:68)
        at java.base/sun.nio.ch.ChannelOutputStream.write(ChannelOutputStream.java:105)
        at java.base/java.io.OutputStream.write(OutputStream.java:124)
        at mill.runner.Watching$.writeToWatchLog$1(Watching.scala:120)
        at mill.runner.Watching$.$anonfun$watchAndWait$15(Watching.scala:184)
        at mill.runner.Watching$.$anonfun$watchAndWait$15$adapted(Watching.scala:183)
        at os.watch.WatchServiceWatcher.run(WatchServiceWatcher.scala:152)
        at os.watch.package$$anon$1.run(package.scala:45)

@lihaoyi lihaoyi marked this pull request as draft May 13, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants