Make runBackground use process IDs (0.12.x branch)
#5120
Merged
+268
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kground-using-pid-0.12.x' into improvement/run-background-using-pid-0.12.x
…ackground-using-pid-0.12.x # Conflicts: # build.mill
…kground-using-pid-0.12.x' into improvement/run-background-using-pid-0.12.x
…-pid-0.12.x' into improvement/run-background-using-pid-0.12.x
lihaoyi
pushed a commit
that referenced
this pull request
May 19, 2025
Currently the `runBackground` uses file locks and generated UUIDs for coordination. This sometimes leads to the cases where a new background process is launched while the old one is still running because the JVM seems to release file locks before network sockets. Because Mill now uses JDK 11, we can use it's APIs to transition to process id based watching, which should alleviate this problem. `0.12.x` branch backport: #5120 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
…ackground-using-pid-0.12.x
…-pid-0.12.x' into improvement/run-background-using-pid-0.12.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5115