Added mappings for Java plugins in ./mill init#6745
Closed
ajaychandran wants to merge 6 commits into
Closed
Conversation
e423392 to
2b0aca3
Compare
- `mill.javalib.checkstyle.CheckstyleModule` The code for generating meta-build files was segregated for reuse in YAML build file generation. The code for transforming the build was encapsulated in `BuildSpec`. Other enhancements/fixes: - Added mapping for `spring-boot-starter-test` dependency (resolves com-lihaoyi#6077)
- Added mapping for `mill.javalib.palantirformat.PalantirFormatModule` - Added mapping for `mill.javalib.spotless.SpotlessModule` - Added mapping for `mill.javalib.revapi.RevapiModule` - Added mapping for `de.tobiasroeser.mill.jacoco.JacocoTestModule` - Fixed YAML encoding for `PomSettings` - Added mapping for `JavaModule.annotationProcessorsMvnDeps` (eg: Lombok) - Resolved com-lihaoyi#6827 by fixing handling of space delimited values - Resolved com-lihaoyi#6865 by fixing YAML encoding for `PomSettings` - Resolved com-lihaoyi#6876 by setting Gradle installation/version for projects that do not define a Gradle wrapper
./mill init./mill init
2b0aca3 to
cabc3e6
Compare
./mill init./mill init
lefou
reviewed
Apr 13, 2026
lefou
left a comment
Member
There was a problem hiding this comment.
The PR description only mentions fixes and additions, but I see also removals (BuildGen, extends BuildGen, override def writeBuildFiles, BuildGenUtil), renames (BuildSpec) and re-ordered parameter lists, which are worth a discussion. I'd prefer to have more incremental improvements. Currently, each PR feels like a complete overhaul.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added mappings for
mill.javalib.pmd.PmdModulemill.javalib.palantirformat.PalantirFormatModulemill.javalib.spotless.SpotlessModulemill.javalib.revapi.RevapiModulede.tobiasroeser.mill.jacoco.JacocoTestModuleOther enhancements/fixes:
JavaModule.annotationProcessorsMvnDeps(eg: Lombok)PomSettingsBuildSpecfor encapsulating build transformations and configuring build file generation.spring-boot-starter-testdependency (resolves Make./mill initwork for spring-boot-examples project #6077)