Split out globalExclusive = true flag from vanilla exclusive = true#7069
Merged
Conversation
Member
Author
|
Seems CI mostly passed on my fork https://github.com/lihaoyi/mill-1/actions/runs/25316708936/job/74216990258 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #6955
exclusive = truemakes the command exclusive only within this launcher, which is used for commands that you want to run single-threaded per launcher e.g. to avoid interleaving with other tasks in the terminal logs, whereasglobalExclusive = truetakes the global exclusive write lock which is useful for tasks which actually do global side effects that should not be run concurrently even with other launchers.Most
exclusive = truetasks remain unchanged, but those likeclean,bspClean,scalafmt,init, etc. are marked likeglobalExclusive = trueas part of this PRAlso includes some code to make sure we release the locks when doing nested evaluations, so e.g.
showevaluating tasks uses the locking strategy of the tasks it evaluates