Generalize @flatten annotation to work on any JSON-serializable key type rather than just String
#694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to allow the keys to be
BufferedValues or other non-Stringdata types, which is useful as it can store theindex: Intfor error reporting purposes laterSome of the existing traits needed to be copy-pasted to allow modification while leaving the old implementations in place for binary compatibility.
Also bumped Mill to 1.1.0-RC3, moved the
mill-jvm-indextodef jvmIdconfigs, and bumped the various Scala/Scala.js/Scala-Native versionsCovered by some small unit tests. The Big150 test fails with a stackoverflow on Scala 3.3.7, just commenting it out for now and hoping that on more modern versions of Scala the compiler folks would have fixed these pathological cases