refactor: LDEPF service - simplify structure by removing Adapter class, closes #505, RSR-1244 #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
e85b1b1 to
9244f56
Compare
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
9244f56 to
a5ff4ff
Compare
samirromdhani
force-pushed
the
fix/498_RSR-1238_processing_LDEPF
branch
2 times, most recently
from
64fbacb to
d4483d1
Compare
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
a5ff4ff to
72aa950
Compare
samirromdhani
force-pushed
the
fix/498_RSR-1238_processing_LDEPF
branch
from
d4483d1 to
62b5a0d
Compare
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
4 times, most recently
from
fd0d434 to
cde3803
Compare
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
cde3803 to
c0c0fe1
Compare
gleizesDor
reviewed
May 6, 2025
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/api/LnEditor.java
Show resolved
Hide resolved
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
2 times, most recently
from
0757eac to
a61062d
Compare
massifben
reviewed
May 7, 2025
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
massifben
reviewed
May 7, 2025
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
a61062d to
aa960c2
Compare
samirromdhani
added a commit
that referenced
this pull request
May 7, 2025
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani
added a commit
that referenced
this pull request
May 9, 2025
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
5e5973b to
b92e664
Compare
samirromdhani
added a commit
that referenced
this pull request
May 9, 2025
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
b92e664 to
bef6330
Compare
samirromdhani
added a commit
that referenced
this pull request
May 13, 2025
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
bef6330 to
6512a1e
Compare
samirromdhani
added a commit
that referenced
this pull request
May 14, 2025
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
6512a1e to
b74648d
Compare
massifben
approved these changes
May 14, 2025
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/domain/DataAttribute.java
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
samirromdhani
added a commit
that referenced
this pull request
May 14, 2025
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
b74648d to
2827570
Compare
samirromdhani
added a commit
that referenced
this pull request
May 14, 2025
closes #505, RSR-1244 Signed-off-by: Samir Romdhani <[email protected]> refactor: review #506#discussion_r2077258522 Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
2827570 to
2028051
Compare
closes #505, RSR-1244 Signed-off-by: Samir Romdhani <[email protected]> refactor: review #506#discussion_r2077258522 Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani
force-pushed
the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
from
2028051 to
a612c36
Compare
samirromdhani
deleted the
refactor/505-RSR-1244-ldepf-service-to-simplify-structure-and-remove-adapter-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #505