Feat switch to scl-lib for loading nsds #15
Conversation
Because the rootDir is everything and we're including .ts files, this catches the *.d.ts files too. So this tweak excludes those to reduce errors about files being overwritten.
scl-lib bundles all nsd files (as strings) which removes any need to fetch these files during bootstrapping. Also insures they'll never been loaded multiple times.
stee-re
changed the title
stee-re
force-pushed
the
feat_switch-to_scl-lib_for-loading-nsds
branch
from
8518a46 to
7242256
Compare
Integration Test issueAn integration test (snapshot comparison) is failing. The test uploads an nsd file and checks it was loaded. Then compares a snapshot of the Settings dialog state. As far as I can understand, when an nsd is uploaded, the list-item should NOT be disabled. I have the feeling the snapshot is holding the wrong state. Its indicating all nsd list items should be disabled. But when an nsd is uploaded (and is valid), shouldn't the appropriate list item be enabled? Is it possible, performance improvements (brought by using scl-lib's resources instead of multiple await-fetches) and changed the timing enough that we're now seeing the correct state where as before we were not? Basically I need a second set of eyes to tell me if I'm missing something staring me right in the face, or confirm the snapshot was wrong and the fix is to update the snapshot for this test. |
stee-re
force-pushed
the
feat_switch-to_scl-lib_for-loading-nsds
branch
from
7242256 to
13b8573
Compare
Needed to upgrad to typsecript v5 because oscd-api (and others) require nodeResolution="bundler" which is only supported in TS v5+.
1 participant
Small PR which removes the fetching of nsd files bundled in open-scd directly, intead using the nsds bundled in scl-lib. This means, no more fetches during bootstrapping to load the nsds.
Instead of delivering one large PR with an overwhelming number of changes, I opted for smaller bite sized PR's to make the review process less painful