Conversation
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
|
@rvantonder please review |
1 similar comment
|
@rvantonder please review |
|
@rvantonder have you had a chance to work this? |
|
Hey @gliptak I did try I need to update the base image (and push it to docker) and ran into an issue. I'll check in again in some time this week. I wish I could do things a bit faster, busy! |
|
@rvantonder please provide next steps |
|
Thanks @gliptak. I can add this but it's just going to build the base image and not push it to Docker, which is what's really needed to do an actual Docker release. It might help flag issues with e.g., #379 -- for that I still had issues building locally, and it's dependent on pushing up the base dep image for Docker. So even if this GH build succeeds, I still need it to build manually and then push the image upstream (I don't want to have to manage secrets with GH build to push to Docker on every push, that's kind of too much hassle for me to maintain--the Dockerfile is there as a DIY solution if folks want to use Docker, so it is best if I just update it manually locally with my credentials). Let me see if I can merge #379, I will try build the base image and push up to Docker first. |
|
thank you @rvantonder consider publishing to ghcr.io which doesn't require additional credentials (like https://github.com/gliptak/aws-cdk-python/pkgs/container/aws-cdk-python) I'm open to submit a followup PR implementing |
|
@rvantonder please provide next steps |
https://github.com/gliptak/comby/actions/runs/15229326177/job/42835277008