Skip to content

ci: add run.sh to otel/distributed_tracing - #20

Merged
LeoRoccoBreedt merged 4 commits into
mainfrom
lrb/otel-distributed-tracing-ci
Jul 1, 2026
Merged

ci: add run.sh to otel/distributed_tracing#20
LeoRoccoBreedt merged 4 commits into
mainfrom
lrb/otel-distributed-tracing-ci

Conversation

@LeoRoccoBreedt

@LeoRoccoBreedt LeoRoccoBreedt commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds run.sh for the OTel distributed tracing example
  • Supports dry-run (no credentials) — prints trace tree locally
  • Sends real traces to Opik when OPIK_API_KEY + OPIK_WORKSPACE are set; no extra OPIK_OTEL_ENDPOINT secret needed (defaults to Opik Cloud)

Test plan

  • Ran locally in dry-run mode
  • Ran locally with credentials — traces visible in Opik
  • CI passed against lrb/ci-workflows

🤖 Generated with Claude Code

@LeoRoccoBreedt
LeoRoccoBreedt marked this pull request as draft June 26, 2026 15:39
@LeoRoccoBreedt
LeoRoccoBreedt changed the base branch from lrb/ci-workflows to main June 29, 2026 13:58
@fschlz

fschlz commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Review against current main (PR #16 merged) — looks good, mergeable after a rebase.

Only adds run.sh (correct name, set -e + export OPIK_PROJECT_NAME ✓), no .github/docs churn, and both scripts support DRY_RUN — so the merged secrets-free dry-run job should pass.

Three quick confirms before merge:

  1. git rebase origin/main (base moved since this was opened).
  2. The merged lint job runs both ruff check . and ruff format --check . — confirm uv run ruff format --check . is clean, not just check.
  3. cd integrations/otel/distributed_tracing && bash run.sh exits 0 with no credentials (the dry-run job), and logs traces with creds (the live-run job).

LeoRoccoBreedt and others added 2 commits July 1, 2026 15:31
The reconciled pr-test.yml lint job runs `ruff format --check` with ruff
0.15.20, which reflows two pre-existing files in this folder. Apply the
formatting so the lint job passes. No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@LeoRoccoBreedt
LeoRoccoBreedt marked this pull request as ready for review July 1, 2026 14:39
@LeoRoccoBreedt
LeoRoccoBreedt merged commit 42f3d85 into main Jul 1, 2026
7 checks passed
@LeoRoccoBreedt
LeoRoccoBreedt deleted the lrb/otel-distributed-tracing-ci branch July 1, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants