[integration] Added Haystack integration - #54
Conversation
|
Thanks @lucifertrj — this one's in great shape. I checked out the branch and ran the CI-equivalent checks locally:
Nice work updating the Should-fix1. Give the load-bearing OpikConnector(name="haystack-multi-agent-scout", project_name=config.OPIK_PROJECT_NAME)This is the single most important line in the example — its constructor swaps in the global # WHY: constructing OpikConnector registers Opik as Haystack's global tracer for the whole
# process; the instance is intentionally unused because we run Agents directly, not via a Pipeline.
OpikConnector(name="haystack-multi-agent-scout", project_name=config.OPIK_PROJECT_NAME)(Your example README explains this in prose already — this is just so the code itself does too.) Minor bonus: it's created inside 2.
Someone who copies Nits
Otherwise this is approvable once 1 and 2 are in. Thanks for a clean, well-structured integration! |
|
perfect. I missed the .env.example part for the project name. I will make the fix. |
|
resolved:
|
What & why
This PR adds support to the Haystack Framework- Deepset integration with the OPIK connector. Issue: #44
Checklist
integrations/guides/use-cases/scripts)lowercase_with_underscoresREADME.mdhas all required sections; index tables updated if examples were added/renamed/removedbash run.shexits cleanly (this is what CI's secrets-free job runs)uv run ruff check .anduv run ruff format --check .are clean.envfiles committedpyproject.toml(uv project); norequirements.txt, no committeduv.lockrun.shexists and starts withset -eOPIK_PROJECT_NAMEis set — exported inrun.sh(scripts) or defined inconfig.py(use-cases/guides)