[OPIK-668]: BaseMetric safer defaults #1826
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit fd16bbb. |
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit fd16bbb. ♻️ This comment has been updated with latest results. |
andrescrz
reviewed
Apr 14, 2025
Comment on lines
+36
to
+37
| def __init__(self, name: str | None = None, track: bool = True) -> None: | ||
| self.name = name if name is not None else self.__class__.__name__ |
There was a problem hiding this comment.
I believe the following would be enough:
def __init__(self, name: str = None, track: bool = True) -> None:
self.name = name if name is not None else self.__class__.__name__
Or even better:
def __init__(self, name: str = __class__.__name__, track: bool = True) -> None:
self.name = name
There was a problem hiding this comment.
@ldaugusto @andrescrz
BaseMetric is not supposed to be instantiated directly, it's a base for other metric classes. So, there is no point in adding a default value to it at all, subclasses will have their own default names anyway.
I suggest closing the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…default
Details
Issues
Resolves #
Testing
Documentation