NO-OPIK fix sign up error leading to flakiness in demo-data test #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses a sign-up error causing test flakiness by generating a random suffix that avoids consecutive repeating characters.
- Added a new helper function, generate_suffix_no_consecutive, to produce a random string with no adjacent duplicate characters.
- Updated temp_user_with_api_key fixture to leverage the new function for generating the random suffix.
Comments suppressed due to low confidence (1)
tests_end_to_end/tests/Admin/conftest.py:47
- [nitpick] While 'generate_suffix_no_consecutive' accurately describes its behavior, consider renaming it (e.g., 'generate_username_suffix') if its use is primarily for generating user-related strings.
random_suffix = generate_suffix_no_consecutive(length=20)
| allowed_chars = string.ascii_lowercase + string.digits | ||
| if len(allowed_chars) < 2 and length > 1: | ||
| raise ValueError( | ||
| "Cannot generate non-consecutive string of length > 1 with < 2 unique characters." |
There was a problem hiding this comment.
Consider including the provided 'length' value in the ValueError message to aid debugging when the set of allowed characters is insufficient.
Suggested change
| "Cannot generate non-consecutive string of length > 1 with < 2 unique characters." | |
| f"Cannot generate non-consecutive string of length {length} with < 2 unique characters." |
Copilot uses AI. Check for mistakes.
andrescrz
approved these changes
May 5, 2025
| return "" | ||
|
|
||
| allowed_chars = string.ascii_lowercase + string.digits | ||
| if len(allowed_chars) < 2 and length > 1: |
There was a problem hiding this comment.
Minor: validation is a bit pointless, as these are built-in constants and the alphabet and digits won't change anytime soon haha.
string.ascii_lowercase + string.digits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.