[OPIK-5767] [SDK] [DOCS] feat: add agent spec integration in python SDK#5769
Open
cesarebernardis wants to merge 1 commit intocomet-ml:mainfrom
Open
Conversation
github-actions
bot
added
documentation
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
sdks/python/tests/library_integration/agentspec/test_agentspec.py
Outdated
Show resolved
Hide resolved
sdks/python/tests/library_integration/agentspec/test_agentspec.py
Outdated
Show resolved
Hide resolved
sdks/python/src/opik/integrations/agentspec/opik_spanprocessor.py
Outdated
Show resolved
Hide resolved
sdks/python/src/opik/integrations/agentspec/opik_spanprocessor.py
Outdated
Show resolved
Hide resolved
cesarebernardis
force-pushed
the
cesarebernardis/issue-5767-agent-spec-integration
branch
from
324760f to
a131751
Compare
cesarebernardis
force-pushed
the
cesarebernardis/issue-5767-agent-spec-integration
branch
from
a131751 to
b83cea0
Compare
sdks/python/tests/library_integration/agentspec/test_agentspec.py
Outdated
Show resolved
Hide resolved
Author
|
Hi @jverre , I am pinging you as agreed in our recent call. I think that the PR is ready, I left a couple of comments I received from the bot open as I am not sure if I should address the issues or not, let me know what you think. |
cesarebernardis
force-pushed
the
cesarebernardis/issue-5767-agent-spec-integration
branch
from
b83cea0 to
0383f8d
Compare
Contributor
|
@cesarebernardis can you address the baz-bot review comments? |
cesarebernardis
force-pushed
the
cesarebernardis/issue-5767-agent-spec-integration
branch
from
0383f8d to
12dcdf4
Compare
Contributor
|
Thanks for the update! Just a note that I can only save feedback related to specific code review findings to memory, not general or PR-level comments. |
Contributor
|
Thanks for the update—appreciate the follow-up! |
Author
Hi @dsblank, I addressed the comments |
cesarebernardis
force-pushed
the
cesarebernardis/issue-5767-agent-spec-integration
branch
from
12dcdf4 to
c1c235c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Implementation of the Agent Spec integration in the Opik Python SDK.
Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: [yes]
Testing
Tested mainly happy path.
Tested also in local environment (docker) to check correctness of functionalities.
Documentation
Updated relevant documentation.