-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[OPIK-4721] Use playground permission #5922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anastasiapyzhik
wants to merge
8
commits into
main
Choose a base branch
from
nastassia/OPIK-4721/use-playground-permission
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
02ee07b
[OPIK-4721] add new permission
anastasiapyzhik 8031010
[OPIK-4721] add page guards
anastasiapyzhik 05bbce4
[OPIK-4721] hide playground in sidebar menu
anastasiapyzhik 4c0daa3
[OPIK-4721] hide playground CTAs
anastasiapyzhik e5160e2
Merge branch 'main' into nastassia/OPIK-4721/use-playground-permission
anastasiapyzhik 554ecf1
[OPIK-4721] guard confirmation dialog
anastasiapyzhik 1561dfe
Merge branch 'main' into nastassia/OPIK-4721/use-playground-permission
anastasiapyzhik e24bf5b
Merge branch 'main' into nastassia/OPIK-4721/use-playground-permission
anastasiapyzhik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
apps/opik-frontend/src/v1/layout/PlaygroundPageGuard/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { usePermissions } from "@/contexts/PermissionsContext"; | ||
| import NoAccessPageGuard from "@/v1/layout/NoAccessPageGuard/NoAccessPageGuard"; | ||
|
|
||
| const PlaygroundPageGuard = () => { | ||
| const { | ||
| permissions: { canUsePlayground }, | ||
| } = usePermissions(); | ||
|
|
||
anastasiapyzhik marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return ( | ||
| <NoAccessPageGuard | ||
| canViewPage={canUsePlayground} | ||
| message="You don't have permissions to use playground in this workspace." | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default PlaygroundPageGuard; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
apps/opik-frontend/src/v2/layout/PlaygroundPageGuard/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { usePermissions } from "@/contexts/PermissionsContext"; | ||
| import NoAccessPageGuard from "@/v2/layout/NoAccessPageGuard/NoAccessPageGuard"; | ||
|
|
||
| const PlaygroundPageGuard = () => { | ||
| const { | ||
| permissions: { canUsePlayground }, | ||
| } = usePermissions(); | ||
|
|
||
| return ( | ||
| <NoAccessPageGuard | ||
| canViewPage={canUsePlayground} | ||
| message="You don't have permissions to use playground in this workspace." | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default PlaygroundPageGuard; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.