[DO NOT MERGE] test(ci): validate GH_PAT_TO_ACCESS_GITHUB_API as release-push token - #32
Closed
CRThaze wants to merge 2 commits into
Closed
[DO NOT MERGE] test(ci): validate GH_PAT_TO_ACCESS_GITHUB_API as release-push token#32CRThaze wants to merge 2 commits into
CRThaze wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
📊 Helm Render Diff SummaryChart
🎉 No changes detected in any of the tested configurations! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. Test-only.
Validates that
secrets.GH_PAT_TO_ACCESS_GITHUB_APIis a safe drop-in replacement forsecrets.GHA_COMMIT_TO_MASTER_PAT, as proposed in #13.Why this needs validating
In
release.yaml, thead-m/github-push-actionstep pushes the helm-docs README commit directly tomain.mainis guarded by the "Protect Main" ruleset (PR + code-owner review +verify-version), so a direct push only succeeds when the token's identity is a member of a bypass team:deployment-teamordeployment-team-actions. The old PAT pushed asCometActions, which is in both.So the swap in #13 works iff
GH_PAT_TO_ACCESS_GITHUB_APIauthenticates as an identity that is push-capable and in one of those bypass teams.What the workflow does
.github/workflows/test-pat-validation.yamlruns on this PR (and viaworkflow_dispatch) and:gh api user);main-ruleset bypass (known bypass roster + best-effort live team check) — see the run's step summary;release.yamluses (ad-m/github-push-action), against a throwaway branchpat-validate/<run_id>;mainis never written to.How to read the result
PASS-> the token authenticates, can push, and bypassesProtect Main. Safe to merge Update GitHub Actions token for pushing changes to main branch #13.REVIEWwarning -> the PAT owner is not in a bypass team; add it todeployment-team(-actions)first, or the release push tomainwill be rejected.Cleanup
Close this PR without merging and delete the branch. The one throwaway
pat-validate/*branch is self-deleted by the workflow.