compile-qtwayland5.sh without checkinstall#463
Merged
adeebshihadeh merged 1 commit intocommaai:masterfrom Mar 11, 2025
Merged
Conversation
Contributor
|
Thanks! |
Collaborator
Author
|
Just checked the differences of checkinstall is stripped / no debug info: while the manually built one is not stripped / with debug_info: Also the size is much bigger: Installed-Size: 96.8 MB vs Installed-Size: 8,770 kB. I will see what's the easiest way to do this and submit another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the main ui crashing immediately on startup.
The reason is
checkinstalldoesn't package all the files incompile-qtwayland5.shcorectly because of qmake, so I replaced it withdpkg-deb(which is also used inbuild-qt-deb.shandbuild-libwayland-deb.sh).I have no idea how it worked before. Since the
qtwayland5repo/branch we are using didn't change and neither thecheckinstallversion. Checkinglibqwayland-egl.soon AGNOS v11.10 the file was provided byqtwayland5(correctly), so something changed recently.The
checkinstallerrors weresilentso this is why the build didn't fail:As for
checkinstallin general, it doesn't have proper maintainers anymore and we should migrate from it. The proper replacement is what is used in #408 (but not so readable for our usecase). A simpler solution would be to usedpkg-deband store theDEBIAN/controlfiles separately (or use another tool to generate them - e.g.dh_make).