fix git link: use CURL_LIBCURL for static deps#66
Merged
adeebshihadeh merged 3 commits intomasterfrom Mar 24, 2026
Merged
Conversation
git-remote-http was failing to link on ARM64 with undefined references to dlopen/dlsym from libcrypto.a. The issue was that CURL_LDFLAGS doesn't affect the CURL_LIBCURL variable that git uses to link git-remote-http. Use CURL_LIBCURL directly so all static deps (-lssl -lcrypto -lz -lpthread -ldl) are included. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Two issues: 1. ARM64: git-imap-send links openssl directly (not via curl), so CURL_LIBCURL alone isn't enough. Override OPENSSL_LIBSSL and LIB_4_CRYPTO to include transitive deps (-ldl, -lpthread). 2. macOS: autoreconf (needed by curl build) wasn't installed. Add autoconf/automake/libtool to brew install. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
curl on macOS uses SCDynamicStoreCopyProxies from the SystemConfiguration framework for proxy detection. Add -framework SystemConfiguration/Security/CoreFoundation to the link flags on Darwin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.