sync terrain shader texture2D -> texture from main#14
Open
utkarshgill wants to merge 1 commit intocommaai:minimalfrom
Open
sync terrain shader texture2D -> texture from main#14utkarshgill wants to merge 1 commit intocommaai:minimalfrom
utkarshgill wants to merge 1 commit intocommaai:minimalfrom
Conversation
terrain.frag.glsl on minimal uses deprecated texture2D() in a #version 330 shader. macos enforces glsl 3.30 core profile where texture2D is removed, breaking terrain/road rendering in sim. this change already exists on main via 0dd67b8. file content checked out directly from that commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: commaai/openpilot#37526
terrain.frag.glsl on minimal uses deprecated
texture2D()in a#version 330shader. macos enforces glsl 3.30 core profile wheretexture2Dis removed, breaking terrain/road rendering in sim.this change already exists on main via 0dd67b8. file content checked out directly from that commit.
related: metadriverse#872