Skip to content

refactor: create StatisticsBar#239

Merged
incognitojam merged 6 commits intocommaai:masterfrom
greatgitsby:refactor/stats-bar
Mar 25, 2025
Merged

refactor: create StatisticsBar#239
incognitojam merged 6 commits intocommaai:masterfrom
greatgitsby:refactor/stats-bar

Conversation

@greatgitsby
Copy link
Copy Markdown
Contributor

@greatgitsby greatgitsby commented Mar 25, 2025

Would love this StatisticBar for commaai/connect#203 to reuse spacing and styling

also inlined a few types to reduce LoC

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2025

This branch is behind commaai/master. The line count diff bot is disabled.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2025

deployed preview: https://239.connect-d5y.pages.dev

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@incognitojam incognitojam added the refactor improve structure without changing behavior label Mar 25, 2025
@greatgitsby
Copy link
Copy Markdown
Contributor Author

it's very hard to test loading code because everything loads so fast 😊

Copy link
Copy Markdown
Collaborator

@incognitojam incognitojam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@incognitojam incognitojam merged commit 9ac9b56 into commaai:master Mar 25, 2025
10 checks passed
@greatgitsby greatgitsby deleted the refactor/stats-bar branch March 29, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor improve structure without changing behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants