Skip to content

Fix no pull to refresh #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshane wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix no pull to refresh #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
451a7aa
this?
sshane Apr 3, 2025
95d7f3d
Hide drawer completely (fixes issue in #18)
incognitojam Apr 3, 2025
d925b1c
prevent horizontal scrolling when drawer is open
incognitojam Apr 3, 2025
dd48a41
add PullDownReload component
incognitojam Apr 3, 2025
38ff496
Revert "add PullDownReload component"
incognitojam Apr 3, 2025
1d21e7b
Merge remote-tracking branch 'origin/master' into fix-pull-to-refresh
incognitojam Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/material/Drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ const Drawer: ParentComponent<DrawerProps> = (props) => {
class="hide-scrollbar fixed inset-y-0 left-0 h-full touch-pan-y overflow-y-auto overscroll-y-contain transition-drawer ease-in-out duration-300"
style={{
left: drawerVisible() ? 0 : `${-PEEK}px`,
opacity: drawerVisible() ? 1 : 0.5,
// Opacity should be 0 when drawer is closed, otherwise it can be visible when overscrolling
opacity: drawerVisible() ? 1 : 0,
Comment on lines +51 to +52
Copy link
Copy Markdown
Collaborator

@incognitojam incognitojam Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the bug previously addressed in #18

width: `${drawerWidth()}px`,
}}
>
Expand Down
5 changes: 4 additions & 1 deletion src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,10 @@
* fill visible viewport
* https://developers.google.com/web/updates/2016/12/url-bar-resizing
*/
@apply h-full overflow-hidden;
@apply h-full;

/* prevent horizontal scrolling, e.g. when drawer is open */
@apply overflow-x-hidden;
Comment on lines +125 to +126
Copy link
Copy Markdown
Contributor Author

@sshane sshane Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't notice this, what is it for?

Copy link
Copy Markdown
Collaborator

@incognitojam incognitojam Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have to test the branch as it was in be22dc8. We have to clip the overflow horizontally because we have a couple of animations which translate the UI horizontally:

  • Opening the drawer slides it from left to right slightly, and the rest of the UI slides to the right
  • The route activity slides away to the right when you go back to the route list

Without this you can scroll the whole page horizontally.

}

::-webkit-scrollbar {
Expand Down