Skip to content

fix: Comma logo improvements#516

Closed
greatgitsby wants to merge 2 commits intocommaai:masterfrom
greatgitsby:fix/logo-shift
Closed

fix: Comma logo improvements#516
greatgitsby wants to merge 2 commits intocommaai:masterfrom
greatgitsby:fix/logo-shift

Conversation

@greatgitsby
Copy link
Copy Markdown
Contributor

@greatgitsby greatgitsby commented Apr 7, 2025

  1. fixes a reflow on first load. its better to define w/h via attribute instead of css so the browser knows how to place it before the image loads
  2. switch to the svg version, vector + 100 less bytes!

must merge commaai/connect#515 first, this is a no-line change

before (no-cache refresh)

before.mov

after (both cached and no-cache refresh)

after.mov

class="font-bold"
leading={
<Show when={!modal()} fallback={<DrawerToggleButton />}>
<img alt="Comma logo" src="/images/comma-white.svg" height="32" width="32" />
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2025

This branch is behind commaai/master. The line count diff bot is disabled.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2025

deployed preview: https://516.connect-d5y.pages.dev

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@greatgitsby greatgitsby changed the title fix: Comma logo shifts on first load fix: Comma logo improvements Apr 7, 2025
@greatgitsby greatgitsby marked this pull request as ready for review April 8, 2025 05:40
@incognitojam incognitojam added bugfix fixes an issue design UI/UX discussion or updates labels Apr 8, 2025
@greatgitsby
Copy link
Copy Markdown
Contributor Author

this can be incorporated after this refactor: commaai/connect#517

@greatgitsby greatgitsby closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix fixes an issue design UI/UX discussion or updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants