Skip to content

feat: add Anchor props to ButtonBase #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
incognitojam merged 3 commits into from
Apr 8, 2025
Merged

feat: add Anchor props to ButtonBase #526

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0046fa7
feat: support external target on button
greatgitsby Apr 8, 2025
9c612ba
feat: support external target on button
greatgitsby Apr 8, 2025
b4382d6
this works!
incognitojam Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 6 additions & 31 deletions src/components/material/ButtonBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,13 @@
import { Show, splitProps } from 'solid-js'
import type { Component, JSX } from 'solid-js'
import { A } from '@solidjs/router'
import { splitProps, type Component, type JSX } from 'solid-js'
import { Dynamic } from 'solid-js/web'
import { A, type AnchorProps } from '@solidjs/router'
import clsx from 'clsx'

export type ButtonBaseProps = JSX.ButtonHTMLAttributes<HTMLButtonElement> & {
class?: string
onClick?: (e: MouseEvent) => void
href?: string
activeClass?: string
}
export type ButtonBaseProps = { class?: string } & (AnchorProps | JSX.ButtonHTMLAttributes<HTMLButtonElement>)

const ButtonBase: Component<ButtonBaseProps> = (props) => {
const onClick: JSX.EventHandler<unknown, MouseEvent> = (e: MouseEvent) => {
props.onClick?.(e)
}

const [, rest] = splitProps(props, ['class', 'onClick', 'href'])
return (
<Show
when={props.href}
fallback={
<button class={clsx('relative isolate overflow-hidden', props.class)} onClick={onClick} {...rest}>
{props.children}
</button>
}
keyed
>
{(href) => (
<A class={clsx('relative isolate overflow-hidden', props.class)} onClick={onClick} href={href} activeClass={props.activeClass}>
{props.children}
</A>
)}
</Show>
)
const [, rest] = splitProps(props, ['class'])
return <Dynamic component={'href' in props ? A : 'button'} class={clsx('relative isolate overflow-hidden', props.class)} {...rest} />
}

export default ButtonBase
Loading