added audio toggle to route video player#618
Open
Lossul wants to merge 2 commits intocommaai:masterfrom
Open
Conversation
Changes:
Total lines: 4744 (+6) |
deployed preview: https://618.connect-d5y.pages.devWelcome to connect! Make sure to:
Mobile
Desktop
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an audio toggle to the RouteVideoPlayer to allow users to hear audio from dashboard video clips. Previously, videos were hardcoded to muted with no UI control to unmute.
Verified locally in demo mode that clicking the new volume icon successfully unmutes/mutes the audio and updates the icon state correctly.