Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
109 commits
Select commit Hold shift + click to select a range
b464ceb
Add secoc ACC command
chrispypatt Oct 18, 2024
ce6b289
Remove commented out secoc long disable code
chrispypatt Oct 18, 2024
9d7aeb5
Merge branch 'commaai:master' into secoc-long
chrispypatt Oct 18, 2024
490067a
Add Toyota 2021 SecOC route
chrispypatt Oct 19, 2024
b4c0dfe
Merge branch 'commaai:master' into secoc-long
chrispypatt Nov 2, 2024
a80efda
Send 0 accel for ACC_CONTROL to match stock
chrispypatt Nov 2, 2024
e40e36b
Merge branch 'commaai:master' into secoc-long
chrispypatt Nov 2, 2024
c5aec84
Update opendbc/car/toyota/carcontroller.py
chrispypatt Nov 5, 2024
27d7ff1
Merge branch 'commaai:master' into secoc-long
chrispypatt Nov 5, 2024
d838cea
Merge branch 'commaai:master' into secoc-long
chrispypatt Nov 18, 2024
018b66a
Merge branch 'commaai:master' into secoc-long
chrispypatt Dec 3, 2024
4d2a2c8
Merge branch 'master' into secoc-long
chrispypatt Dec 11, 2024
83f6773
Merge branch 'master' into secoc-long
chrispypatt Dec 13, 2024
95573ec
Merge branch 'master' into secoc-long
chrispypatt Dec 18, 2024
a518449
Merge SecOC long changes from chrispypatt.
PenitentTangent2401 Dec 30, 2024
49f08dc
Add new ACC steering wheel message for SecOC cars. Update distance_bu…
PenitentTangent2401 Dec 30, 2024
b0ff993
Add new DBC file for Toyota SecOC cars.
PenitentTangent2401 Dec 30, 2024
75fcf63
Update Toyota Rav4 Prime and 4th Gen Sienna to use SecOC DBC file.
PenitentTangent2401 Dec 30, 2024
fc029da
Merge branch 'commaai:master' into secoc-long
chrispypatt Dec 31, 2024
0a0e2db
Merge pull request #1 from PenitentTangent2401/distance
chrispypatt Dec 31, 2024
287da0b
Merge remote-tracking branch 'comma/master' into secoc-long
chrispypatt Jan 12, 2025
9399509
Merge branch 'master' into secoc-long
chrispypatt Jan 15, 2025
184929a
Update carstate.py l
chrispypatt Jan 15, 2025
0ea63f5
Merge branch 'master' into secoc-long
chrispypatt Jan 17, 2025
d908d65
dont save button state on secoc
chrispypatt Jan 24, 2025
109354a
Update opendbc/car/toyota/carstate.py
chrispypatt Jan 24, 2025
fef1954
Remove unreachable code
chrispypatt Jan 25, 2025
1d02e07
Merge branch 'commaai:master' into secoc-long
chrispypatt Feb 15, 2025
47abe79
Merge branch 'commaai:master' into secoc-long
chrispypatt Feb 20, 2025
bccfbdc
Move secoc safety to opendbc
chrispypatt Feb 20, 2025
c361ad1
Merge branch 'master' into secoc-long
chrispypatt Feb 21, 2025
636278f
Merge branch 'master' into secoc-long
chrispypatt Feb 22, 2025
5a9e671
Merge remote-tracking branch 'comma/master' into secoc-long
chrispypatt Feb 27, 2025
da0b102
Merge branch 'master' into secoc-long
chrispypatt Mar 3, 2025
015fc13
Merge branch 'master' into secoc-long
chrispypatt Mar 4, 2025
4b26706
Merge branch 'master' into secoc-long
chrispypatt Mar 6, 2025
7ab4338
Merge branch 'commaai:master' into secoc-long
chrispypatt Mar 7, 2025
b080a60
Update R4P SecOC route
chrispypatt Mar 7, 2025
872a2d2
Merge branch 'master' into secoc-long
chrispypatt Mar 7, 2025
b8f2d43
Merge branch 'master' into secoc-long
chrispypatt Mar 10, 2025
dd50846
Merge branch 'master' into secoc-long
chrispypatt Mar 11, 2025
9344ecb
Build safety with -Wextra
sshane Mar 11, 2025
0de6405
safety: relay malfunction config (#1959)
sshane Mar 11, 2025
944f7a2
Hyundai: dashcam FCEV (#1973)
sshane Mar 11, 2025
feeda99
Hyundai CAN FD: Accurate hybrid powertrain detection (#1891)
sunnyhaibin Mar 11, 2025
be951c8
Tesla: Autopilot enabled signal (#1978)
lukasloetkolben Mar 11, 2025
f4a2514
Tesla: fix incorrect DBC msg length (#1980)
sshane Mar 11, 2025
412b364
Subaru Pre-Global: fix missing rx checks (#1982)
sshane Mar 11, 2025
127fca6
Honda Nidec: missing brake command rx check (#1981)
sshane Mar 11, 2025
fdfc8f3
Honda safety: only test alt brake for alt brake param
sshane Mar 11, 2025
9516061
safety tests: remove redundant test skips (#1983)
sshane Mar 12, 2025
f7a8175
GM safety: add missing regen rx check (#1984)
sshane Mar 12, 2025
4570e2b
Fingerprint: 2022 Civic Si (#1952)
vanillagorillaa Mar 12, 2025
ffb98d9
Hyundai CAN FD safety: more clear what is common (#1986)
sshane Mar 12, 2025
2915102
Hyundai CANFD safety tests: common safety param combinations (#1987)
sshane Mar 12, 2025
8aa8e92
Hyundai CAN FD safety: replace alt buttons live detection with param …
sshane Mar 12, 2025
8b2162c
Hyundai safety: add missing rx checks (#1989)
sshane Mar 12, 2025
f1e3350
safety: rename allowed
sshane Mar 12, 2025
e711166
safety: only run rx hooks on whitelisted msgs (#1903)
sshane Mar 12, 2025
bb5fa28
Hyundai: Fix FCEV RX check and move out of dashcam (#1974)
sunnyhaibin Mar 12, 2025
2df1502
HKG: spas remove unused frame param (#1966)
royjr Mar 12, 2025
5b438b8
Added FW for Mazda CX5 2025 (#1911)
kenhuang14 Mar 12, 2025
41b67df
Hyundai CAN FD: Fix steering messages in safety replay (#1975)
sunnyhaibin Mar 12, 2025
4aeb000
Hyundai: split car controller by CAN FD (#1990)
sshane Mar 12, 2025
c78b489
Toyota: add static rx check for alt brake (#1991)
sshane Mar 12, 2025
a64125f
whoops bad pull
chrispypatt Mar 12, 2025
382f34e
Merge branch 'master' into secoc-long
chrispypatt Mar 12, 2025
769c528
Merge branch 'master' into secoc-long
chrispypatt Mar 14, 2025
57070f0
Merge branch 'master' into secoc-long
chrispypatt Mar 15, 2025
d3b2a08
Merge branch 'master' into secoc-long
chrispypatt Mar 18, 2025
7676b4a
Merge branch 'master' into secoc-long
chrispypatt Mar 22, 2025
558dac7
Merge branch 'master' into secoc-long
chrispypatt Mar 22, 2025
9b48cc3
Merge branch 'master' into secoc-long
chrispypatt Mar 26, 2025
5d37854
Merge branch 'master' into secoc-long
chrispypatt Mar 30, 2025
fa87739
Merge branch 'master' into secoc-long
chrispypatt Apr 1, 2025
ab8a0e3
PR suggestions
chrispypatt Apr 3, 2025
2df7ce7
Merge branch 'master' into secoc-long
chrispypatt Apr 3, 2025
4bec658
Remove unnecessary parens
chrispypatt Apr 3, 2025
be4653d
PR suggestions
chrispypatt Apr 5, 2025
8edf38f
Fix some logical errors
chrispypatt Apr 5, 2025
8f563ac
Fix tester present test
chrispypatt Apr 5, 2025
2cf6843
Merge remote-tracking branch 'comma/master' into secoc-long
chrispypatt Apr 10, 2025
379c8a1
Merge remote-tracking branch 'origin' into secoc-long
chrispypatt Apr 10, 2025
46efd79
Merge branch 'master' into secoc-long
chrispypatt Apr 10, 2025
7df4b4c
Merge branch 'master' into secoc-long
chrispypatt Apr 10, 2025
8d6ae3e
Merge branch 'master' into secoc-long
chrispypatt Apr 14, 2025
d2a85a1
Update safety for non-op long secoc
chrispypatt Apr 15, 2025
955a6b9
Merge branch 'master' into secoc-long
chrispypatt Apr 15, 2025
ef8fe56
Update tests
chrispypatt Apr 15, 2025
c515573
Update safety
chrispypatt Apr 15, 2025
92c9d0a
Update tests
chrispypatt Apr 15, 2025
f565d2f
Merge branch 'master' into secoc-long
chrispypatt Apr 15, 2025
f9dbd49
Merge branch 'master' into secoc-long
chrispypatt Apr 18, 2025
3fdacca
Merge branch 'master' into secoc-long
chrispypatt Apr 19, 2025
a430188
Merge branch 'master' into secoc-long
chrispypatt Apr 30, 2025
3e577d1
Merge branch 'master' into secoc-long
chrispypatt May 2, 2025
1b22879
Merge branch 'master' into secoc-long
chrispypatt May 10, 2025
2d22a99
Merge branch 'master' into secoc-long
chrispypatt May 12, 2025
2c918a0
Merge branch 'master' into secoc-long
chrispypatt May 13, 2025
34b80e4
Merge branch 'master' into secoc-long
chrispypatt May 16, 2025
b2c6846
Merge remote-tracking branch 'comma/master' into secoc-long
chrispypatt May 21, 2025
6c8f369
Merge branch 'commaai:master' into secoc-long
chrispypatt May 23, 2025
f035559
Merge remote-tracking branch 'origin' into secoc-long
chrispypatt Jul 3, 2025
0261d4b
Merge branch 'master' into secoc-long
wtogami Jul 20, 2025
0b05e00
Merge pull request #3 from wtogami/secoc-long
chrispypatt Jul 20, 2025
2b580c5
Merge branch 'master' of ssh://github.com/commaai/opendbc into secoc-…
jyoung8607 Aug 27, 2025
4196b97
whitespace adjustment for clarity
jyoung8607 Aug 27, 2025
8521e18
Merge branch 'master' into secoc-long
chrispypatt Sep 22, 2025
ff272b1
PR suggestions
chrispypatt Sep 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions opendbc/car/tests/routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ class CarTestRoute(NamedTuple):
CarTestRoute("7e34a988419b5307|2019-12-18--19-13-30", TOYOTA.TOYOTA_RAV4_TSS2), # hybrid
CarTestRoute("2475fb3eb2ffcc2e|2022-04-29--12-46-23", TOYOTA.TOYOTA_RAV4_TSS2_2022), # hybrid
CarTestRoute("20ba9ade056a8c7b|2021-02-08--21-57-35", TOYOTA.TOYOTA_RAV4_PRIME), # SecOC
CarTestRoute("41ba5b181f29435d/00000075--b8cdba16c8", TOYOTA.TOYOTA_RAV4_PRIME), # SecOC
Comment thread
chrispypatt marked this conversation as resolved.
Outdated
Comment thread
chrispypatt marked this conversation as resolved.
Outdated
CarTestRoute("8bfb000e03b2a257/00000004--f9eee5f52e", TOYOTA.TOYOTA_SIENNA_4TH_GEN), # SecOC
CarTestRoute("7a31f030957b9c85|2023-04-01--14-12-51", TOYOTA.LEXUS_ES),
CarTestRoute("37041c500fd30100|2020-12-30--12-17-24", TOYOTA.LEXUS_ES), # hybrid
Expand Down
19 changes: 17 additions & 2 deletions opendbc/car/toyota/carcontroller.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def __init__(self, dbc_name, CP):

self.secoc_lka_message_counter = 0
self.secoc_lta_message_counter = 0
self.secoc_acc_message_counter = 0
self.secoc_prev_reset_counter = 0
self.secoc_mismatch_counter = 0

Expand All @@ -68,6 +69,7 @@ def update(self, CC, CS, now_nanos):
if CS.secoc_synchronization['RESET_CNT'] != self.secoc_prev_reset_counter:
self.secoc_lka_message_counter = 0
self.secoc_lta_message_counter = 0
self.secoc_acc_message_counter = 0
Comment thread
sshane marked this conversation as resolved.
self.secoc_prev_reset_counter = CS.secoc_synchronization['RESET_CNT']

expected_mac = build_sync_mac(self.secoc_key, int(CS.secoc_synchronization['TRIP_CNT']), int(CS.secoc_synchronization['RESET_CNT']))
Expand Down Expand Up @@ -210,8 +212,21 @@ def update(self, CC, CS, now_nanos):
# internal PCM gas command can get stuck unwinding from negative accel so we apply a generous rate limit
pcm_accel_cmd = min(pcm_accel_cmd, self.accel + ACCEL_WINDUP_LIMIT) if CC.longActive else 0.0

can_sends.append(toyotacan.create_accel_command(self.packer, pcm_accel_cmd, pcm_cancel_cmd, self.permit_braking, self.standstill_req, lead,
CS.acc_type, fcw_alert, self.distance_button))
if self.CP.flags & ToyotaFlags.SECOC.value:
can_sends.append(toyotacan.create_accel_command(self.packer, 0, pcm_cancel_cmd, self.permit_braking, self.standstill_req, lead,
CS.acc_type, fcw_alert, self.distance_button))
acc_cmd_2 = toyotacan.create_accel_command_2(self.packer, pcm_accel_cmd)
acc_cmd_2 = add_mac(self.secoc_key,
int(CS.secoc_synchronization['TRIP_CNT']),
int(CS.secoc_synchronization['RESET_CNT']),
self.secoc_acc_message_counter,
acc_cmd_2)
self.secoc_acc_message_counter += 1
can_sends.append(acc_cmd_2)
else:
can_sends.append(toyotacan.create_accel_command(self.packer, pcm_accel_cmd, pcm_cancel_cmd, self.permit_braking, self.standstill_req, lead,
CS.acc_type, fcw_alert, self.distance_button))

Comment thread
chrispypatt marked this conversation as resolved.
self.accel = pcm_accel_cmd
else:
can_sends.append(toyotacan.create_accel_command(self.packer, 0, pcm_cancel_cmd, True, False, lead, CS.acc_type, False, self.distance_button))
Expand Down
9 changes: 3 additions & 6 deletions opendbc/car/toyota/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,9 @@ def _get_params(ret: structs.CarParams, candidate, fingerprint, car_fw, experime
# openpilot longitudinal behind experimental long toggle:
# - TSS2 radar ACC cars (disables radar)

if ret.flags & ToyotaFlags.SECOC.value:
ret.openpilotLongitudinalControl = False
else:
ret.openpilotLongitudinalControl = ret.enableDsu or \
candidate in (TSS2_CAR - RADAR_ACC_CAR) or \
bool(ret.flags & ToyotaFlags.DISABLE_RADAR.value)
ret.openpilotLongitudinalControl = ret.enableDsu or \
candidate in (TSS2_CAR - RADAR_ACC_CAR) or \
bool(ret.flags & ToyotaFlags.DISABLE_RADAR.value)

ret.autoResumeSng = ret.openpilotLongitudinalControl and candidate in NO_STOP_TIMER_CAR

Expand Down
5 changes: 5 additions & 0 deletions opendbc/car/toyota/toyotacan.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ def create_accel_command(packer, accel, pcm_cancel, permit_braking, standstill_r
}
return packer.make_can_msg("ACC_CONTROL", 0, values)

def create_accel_command_2(packer, accel):
values = {
"ACCEL_CMD": accel,
}
return packer.make_can_msg("ACC_CONTROL_2", 0, values)

def create_pcs_commands(packer, accel, active, mass):
values1 = {
Expand Down