Skip to content

Forward-declare dlc_to_len#2248

Closed
aubsw wants to merge 4 commits intocommaai:masterfrom
aubsw:fix-static-inclusions
Closed

Forward-declare dlc_to_len#2248
aubsw wants to merge 4 commits intocommaai:masterfrom
aubsw:fix-static-inclusions

Conversation

@aubsw
Copy link
Copy Markdown
Contributor

@aubsw aubsw commented May 15, 2025

Make dlc_to_len non-statically declared in can.h so that we can properly include can.h and can_declarations.h in panda and OP without compiler issues.

This also addresses the fact that that dlc_to_len is referenced in can_declarations.h before it's declared.

@github-actions github-actions bot added the car safety vehicle-specific safety code label May 15, 2025
@aubsw aubsw marked this pull request as ready for review May 15, 2025 21:59
@aubsw aubsw mentioned this pull request May 15, 2025
@aubsw aubsw force-pushed the fix-static-inclusions branch from c5d16db to 35beec5 Compare May 15, 2025 22:53
@aubsw aubsw changed the title Delete can.h Forward-declare dlc_to_len May 15, 2025
@aubsw aubsw closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car safety vehicle-specific safety code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant