Add support for Jeep Grand Cherokee SRT 2016-18#3265
Draft
alxs1234 wants to merge 27 commits intocommaai:masterfrom
Draft
Add support for Jeep Grand Cherokee SRT 2016-18#3265alxs1234 wants to merge 27 commits intocommaai:masterfrom
alxs1234 wants to merge 27 commits intocommaai:masterfrom
Conversation
Add Jeep Grand Cherokee SRT Specs to values.py
Add JEEP GRAND CHEROKEE SRT
Contributor
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 40 segments for: CHRYSLER_PACIFICA_2018_HYBRID, CHRYSLER_PACIFICA_2019_HYBRID, CHRYSLER_PACIFICA_2018, CHRYSLER_PACIFICA_2020 ✅ 0 changed, 40 passed, 0 errors |
Was added but got removed in push to master
Update logic to send gradually LKAS decrease instead of abrupt 0 to mitigate lkas fault.
Removed SRT hooks for Chrysler from safety.h
Author
|
keeping PR as draft until I can work through errors I'm seeing on vehicle. |
skip cross-mode TX test for shared Pacifica addresses on SRT platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SRT trim uses significantly different steering hardware/ratio than the standard Grand Cherokee, requiring a separate platform entry.
Key differences from JEEP_GRAND_CHEROKEE:
Changes:
Tested on: 2016 Jeep Grand Cherokee SRT (VIN: 1C4RJFDJ3GC420967)
Hardware: comma 4, FCA harness
FFCM: 68251681AF (factory installed, LaneSense enabled via BCM config)
Validation: