Tesla: use DI_accelPedalPressed#3300
Open
dzid26 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
car
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 20 segments for: TESLA_MODEL_3, TESLA_MODEL_Y Show changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tesla has a accelerator pressed signal.
Benefits:
DI_accelPedalPressedreacts to less pressure compared to oldDI_accelPedalPos- this helps to avoid jerking forward in forks that use gas pressed gesture2a251bf8a265ff32/00000487--5fcd84003d/1
DI_accelPedalPressedcould have some filtering - I have not seen noise on it so far - whereasDI_accelPedalPoshas been reported to be noisy on some cars, causing Safety: Blocked TX messages during gas override #2766 (comment)