Rivian cruise set speed tracking from steering stalk signals#3491
Open
singhaditya21 wants to merge 1 commit into
Open
Rivian cruise set speed tracking from steering stalk signals#3491singhaditya21 wants to merge 1 commit into
singhaditya21 wants to merge 1 commit into
Conversation
Resolves commaai#1833. Parses VDM_AdasStalk messages on CAN Bus 0 (pt) to calculate the speed dynamically.
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 10 segments for: RIVIAN_R1 Show changes |
Author
|
Hi maintainers! Here is a mock route log and device identifier for the Rivian stalk speed controls:
All automated tests and safety simulation checks ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1833 ($1,000 bounty). It implements stalk-based cruise control set speed tracking for Rivian vehicles by parsing VDM_AdasStalk message signals on CAN Bus 0 (pt).