Skip to content

Docs: Fix unclear Mazda requirements #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ugtthis wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −2
Open

Docs: Fix unclear Mazda requirements #3492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3769e8
add flag
ugtthis Jun 21, 2026
bb26b0d
mazda
ugtthis Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions opendbc/car/docs_definitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,8 @@ class CarDocs:

# all the parts needed for the supported car
car_parts: CarParts = field(default_factory=CarParts)
# Mazda requires comma power
requires_comma_power: bool = False

merged: bool = True
support_type: SupportType = SupportType.UPSTREAM
Expand Down
12 changes: 10 additions & 2 deletions opendbc/car/mazda/values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
from dataclasses import dataclass, field
from enum import IntFlag
from enum import Enum, IntFlag

from opendbc.car import Bus, CarSpecs, DbcDict, PlatformConfig, Platforms
from opendbc.car.common.conversions import Conversions as CV
from opendbc.car.structs import CarParams
from opendbc.car.docs_definitions import CarHarness, CarDocs, CarParts
from opendbc.car.docs_definitions import CarFootnote, CarHarness, CarDocs, CarParts, Column
from opendbc.car.fw_query_definitions import FwQueryConfig, Request, StdQueries

Ecu = CarParams.Ecu
Expand All @@ -29,6 +29,14 @@ def __init__(self, CP):
class MazdaCarDocs(CarDocs):
package: str = "All"
car_parts: CarParts = field(default_factory=CarParts.common([CarHarness.mazda]))
footnotes: list[Enum] = field(default_factory=lambda: [Footnote.COMMA_POWER_REQUIRED])
requires_comma_power: bool = True


class Footnote(Enum):
COMMA_POWER_REQUIRED = CarFootnote(
"Mazda vehicles <b>require</b> comma power installation.",
Column.MAKE, setup_note=True)


@dataclass(frozen=True, kw_only=True)
Expand Down
Loading