[$100 bounty] Match stock Hyundai button logic#1940
Closed
ksfi wants to merge 2 commits intocommaai:masterfrom
Closed
[$100 bounty] Match stock Hyundai button logic#1940ksfi wants to merge 2 commits intocommaai:masterfrom
ksfi wants to merge 2 commits intocommaai:masterfrom
Conversation
added 2 commits
April 27, 2024 16:53
Contributor
|
We've moved the car safety code into opendbc, please rebase and re-open your PR there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safety checks related to bounty which implements the pause/resume button HKG cars logic
Cruise speed is taken from SCC11 that uses here the same bus logic as SCC12 but i do not have any device so couldn't check
OP PR: commaai/openpilot#32306