Skip to content

[$100 bounty] Match stock Hyundai button logic#32306

Closed
ksfi wants to merge 2 commits intocommaai:masterfrom
ksfi:hkgpauseresume
Closed

[$100 bounty] Match stock Hyundai button logic#32306
ksfi wants to merge 2 commits intocommaai:masterfrom
ksfi:hkgpauseresume

Conversation

@ksfi
Copy link
Copy Markdown
Contributor

@ksfi ksfi commented Apr 27, 2024

Matches stock buttons on HKG cars that have a pause/resume button following bounty #30950
Cancel button is considered as the pause/resume button on cars with the HYUNDAI_PAUSE_RESUME_BTN flag set
Giving a grate on availability is considered equivalent to doing nothing
Considered "for the first time" as for the first main button is pressed ever
The logic still the same when OP longitudinal isn't used

Panda PR: commaai/panda#1940

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 27, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Copy Markdown
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

@sshane sshane closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car vehicle-specific hyundai

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants