[$100 bounty] Match stock Hyundai button logic#32306
Closed
ksfi wants to merge 2 commits intocommaai:masterfrom
Closed
[$100 bounty] Match stock Hyundai button logic#32306ksfi wants to merge 2 commits intocommaai:masterfrom
ksfi wants to merge 2 commits intocommaai:masterfrom
Conversation
Contributor
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
Contributor
|
We've moved the car interfacing code to our PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --rejectSimply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches stock buttons on HKG cars that have a pause/resume button following bounty #30950
Cancel button is considered as the pause/resume button on cars with the
HYUNDAI_PAUSE_RESUME_BTNflag setGiving a grate on availability is considered equivalent to doing nothing
Considered "for the first time" as for the first main button is pressed ever
The logic still the same when OP longitudinal isn't used
Panda PR: commaai/panda#1940