Skip to content

chrysler safety: fix mutations failures #2054

Closed
maxime-desroches wants to merge 8 commits intomasterfrom
vm_chrysler
Closed

chrysler safety: fix mutations failures #2054
maxime-desroches wants to merge 8 commits intomasterfrom
vm_chrysler

Conversation

@maxime-desroches
Copy link
Copy Markdown
Contributor

@maxime-desroches maxime-desroches commented Oct 2, 2024

Add coverage for these lines:

if ((chrysler_platform != CHRYSLER_PACIFICA) && (bus == 0) && (addr == chrysler_addrs->ESP_8)) {
vehicle_moving = ((GET_BYTE(to_push, 4) << 8) + GET_BYTE(to_push, 5)) != 0U;
}
if ((chrysler_platform == CHRYSLER_PACIFICA) && (bus == 0) && (addr == 514)) {
int speed_l = (GET_BYTE(to_push, 0) << 4) + (GET_BYTE(to_push, 1) >> 4);
int speed_r = (GET_BYTE(to_push, 2) << 4) + (GET_BYTE(to_push, 3) >> 4);
vehicle_moving = (speed_l != 0) || (speed_r != 0);

Changed the way the check is done in order to be fully testable

@maxime-desroches maxime-desroches changed the title chrysler: more coverage around setting vehicle_moving chrysler safety: more coverage around setting vehicle_moving Oct 2, 2024
@maxime-desroches maxime-desroches changed the title chrysler safety: more coverage around setting vehicle_moving chrysler safety: fix mutations failures Oct 3, 2024
@sshane
Copy link
Copy Markdown
Contributor

sshane commented Feb 20, 2025

We've moved the car safety code into opendbc, please rebase and re-open your PR there!

@sshane sshane closed this Feb 20, 2025
@sshane sshane deleted the vm_chrysler branch February 20, 2025 06:38
liruifeng1120 pushed a commit to liruifeng1120/panda that referenced this pull request Dec 24, 2025
Fix typo "DISANCE" -> "DISTANCE" in _nissan_common.dbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants