Skip to content

safety_replay: opendbc libsafety + msg sorting #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredyshox merged 2 commits into from
Feb 23, 2025
Merged

safety_replay: opendbc libsafety + msg sorting #2162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da1a5b2
Fix safety_replay
fredyshox Feb 23, 2025
121e468
Sort
fredyshox Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/safety_replay/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from opendbc.car.toyota.values import ToyotaSafetyFlags
from opendbc.car.structs import CarParams
import panda.tests.libsafety.libsafety_py as libsafety_py
from opendbc.safety.tests.libsafety import libsafety_py

def to_signed(d, bits):
ret = d
Expand Down
4 changes: 2 additions & 2 deletions tests/safety_replay/replay_drive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import os
from collections import Counter

from panda.tests.libsafety import libsafety_py
from opendbc.safety.tests.libsafety import libsafety_py
from panda.tests.safety_replay.helpers import package_can_msg, init_segment

# replay a drive to check for safety violations
Expand Down Expand Up @@ -82,7 +82,7 @@ def replay_drive(lr, safety_mode, param, alternative_experience, segment=False):
parser.add_argument("--alternative-experience", type=int, help="Override the alternative experience from the log")
args = parser.parse_args()

lr = LogReader(args.route_or_segment_name[0])
lr = LogReader(args.route_or_segment_name[0], sort_by_time=True)

if None in (args.mode, args.param, args.alternative_experience):
for msg in lr:
Expand Down