jungle: support replaying CAN messages from an SD card (#1981)#2379
Draft
martinl wants to merge 3 commits intocommaai:masterfrom
Draft
jungle: support replaying CAN messages from an SD card (#1981)#2379martinl wants to merge 3 commits intocommaai:masterfrom
martinl wants to merge 3 commits intocommaai:masterfrom
Conversation
martinl
force-pushed
the
jungle-v2-sd-replay
branch
from
b9ed83d to
c149b48
Compare
Contributor
Getting this working on real hardware is the whole point of the bounty. We will not review any hardware-related PRs that haven't been tested on hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for replaying can messages from SD card.
All tests passed, except hardware since I do not have jungle v2. I also did initial code review before submitting PR.
Please review and let me know if any changes or improvements are required. I can also split this into smaller and more readable PR-s if needed.
I would also like to lock the bounty for issue 1981