swap partition type GUIDs between A/B slots#127
Open
andiradulescu wants to merge 2 commits intocommaai:masterfrom
Open
swap partition type GUIDs between A/B slots#127andiradulescu wants to merge 2 commits intocommaai:masterfrom
andiradulescu wants to merge 2 commits intocommaai:masterfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #120
setActiveSlot()now swaps partition type GUIDs between_aand_bcounterparts when switching slots, matching ABL'sSwitchPtnSlots()/SwapPtnGuid().Without GUID swap, ABL's
ValidateSlotGuids(enabled on some devices) rejects slot B becauseboot_bandsystem_bboth have the same inactive placeholder GUID (77036cd4-03d5-42bb-8ed1-37e5a88baa34), producing:ValidateSlotGuids: BootableSlot _b does not have valid guids.GPT.swapSlotGuids()swaps type GUIDs between same-LUN_a/_bpairsQDL.setActiveSlot()detects current slot and only swaps when actually changing slots (matching ABL'sCurrentSlot != NewSlotguard)Test plan
bun testpasses (42 GPT tests including 7 new GUID swap tests with real device GUIDs)bun lintpasses