Skip to content

Setup Guide: Make it clear when comma power is required#322

Open
ugtthis wants to merge 4 commits into
commaai:masterfrom
ugtthis:mazda-setup
Open

Setup Guide: Make it clear when comma power is required#322
ugtthis wants to merge 4 commits into
commaai:masterfrom
ugtthis:mazda-setup

Conversation

@ugtthis

@ugtthis ugtthis commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

Behavior of setup guide when Mazda is selected:

  • the setup note from opendbc repo appear vs saying "There are no specific setup notes for your vehicle."
  • comma power is not an "Optional Step" and is listed as step 6
  • in comma power step, update copy to say comma power is required vs optional

When a non-Mazda car is selected:

  • biggest difference is that comma power optional step shows before comma connect optional step

UI compare

Before After
current-ui.mp4
proposed-changes.mp4

I can split this into multiple PRs like below, lmk:

  • move comma power before comma connect optional step
  • wire required comma power flag into setup data flow
  • update data
  • add comma power UI/UX changes

Related PR opendbc with problem context: commaai/opendbc#3492

@github-actions

Copy link
Copy Markdown
Contributor

deployed preview: https://comma-web--pr322-os5j552z.web.app

Welcome! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

@ugtthis ugtthis marked this pull request as ready for review June 22, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant