Skip to content

Conversation

@drteeth
Copy link
Contributor

@drteeth drteeth commented Jan 14, 2025

Implement stream trimming:

Delete earlier events in a stream up to a given version

@drteeth drteeth requested review from cdegroot and jwilger January 14, 2025 03:12
@jwilger
Copy link
Contributor

jwilger commented Jan 15, 2025

Changes look fine to me. I'm curious what @drteeth and @cdegroot would think about following a process where PRs for net-new functionality like this should always have an accompanying ADR in the new ADR Repo?

@drteeth drteeth marked this pull request as draft January 16, 2025 15:36
@drteeth
Copy link
Contributor Author

drteeth commented Jan 16, 2025

This misses what to do with event handlers that have not yet seen the events that are about to deleted, and it doesn't take into account what to do with events linked into other streams.

Moving the discussion to ADR seems like a good idea

alias EventStore.{EventData, RecordedEvent, Storage, UUID}
alias EventStore.Streams.StreamInfo

def append_to_stream(conn, stream_uuid, expected_version, events, opts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removal intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants