Joelfickson/im 1413 refactor enforce environmental variables ingrid connector processor #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in createClient function
… logging in createClient function
# Conflicts: # processor/src/clients/ingrid/ingrid.client.ts # processor/src/clients/ingrid/types/ingrid.client.type.ts # processor/src/config/index.ts # processor/src/server/plugins/ingrid-shipping.plugin.ts
… and update related configurations
joelfickson
requested review from
leungkinghin-ct and
praveenkumarct
and removed request for
a team
…rce-environmental-variables-ingrid-connector-processor # Conflicts: # processor/src/clients/ingrid/ingrid.client.ts # processor/src/services/ingrid-shipping.service.ts
…rce-environmental-variables-ingrid-connector-processor
harm-meijer
approved these changes
Feb 26, 2025
mariusmhm
suggested changes
Feb 26, 2025
Contributor
mariusmhm
left a comment
mariusmhm
left a comment
There was a problem hiding this comment.
LGTM! have you tried to run npm run connector:post-deploy? I don't see any changes here regarding the post-deploy script, but we are 100% using dotenv there
Collaborator
leungkinghin-ct
left a comment
leungkinghin-ct
left a comment
There was a problem hiding this comment.
Is it same change as this PR?
Collaborator
I agree. Not sure if two PR are 100% identical. It seems we also discussed this point in previous PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.