ci: try aggregate git release - #2754
Conversation
|
| "@commercetools-applications/*", | ||
| "@commercetools-backend/*", | ||
| "@commercetools-frontend/*", | ||
| "!@commercetools-frontend/codemod" | ||
| "@commercetools-local/*", | ||
| "@commercetools-website/*" |
There was a problem hiding this comment.
This is to keep ALL packages linked together, even the private apps (templates, playground, etc). The result is that these packages will get bumped to the same version as the others (even though they won't be released to NPM).
| "@commercetools-applications/*", | ||
| "@commercetools-backend/*", | ||
| "@commercetools-frontend/*", | ||
| "!@commercetools-frontend/codemod" |
There was a problem hiding this comment.
I thought about this again and I think it's better to keep it in sync with the other versions. It would be easier also to document new codemods for specific releases.
| - name: Storing release version for changeset | ||
| id: release_version | ||
| run: echo "::set-output name=value::$(./scripts/print_release_version.sh)" | ||
| shell: bash | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.RELEASE_GITHUB_TOKEN }} |
There was a problem hiding this comment.
We need to "extract" the "next" release version before the changesets/action step, as the value is used for the githubReleaseName and githubTagName config values.
| createGithubReleases: aggregate | ||
| githubReleaseName: v${{ steps.release_version.outputs.value }} | ||
| githubTagName: v${{ steps.release_version.outputs.value }} |
There was a problem hiding this comment.
This is the new additional config
| id: changesets | ||
| uses: changesets/action@v1.3.0 | ||
| # uses: changesets/action@v1.3.0 | ||
| uses: dotansimha/changesets-action@1bd10e16a393db098c8f537c719621962c0d5571 |
There was a problem hiding this comment.
Using this version, as it hasn't been officially released yet. This is a way also to help testing this feature and give feedback.
|
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit 163ade5. |
| "@commercetools-local/*", | ||
| "@commercetools-website/*" |
There was a problem hiding this comment.
Sorry but I don't the inclusion of this packages here. Will this make them visible in the release changesets?
There was a problem hiding this comment.
They all already have changesets, as they are part of the monorepo workspaces. E.g. https://github.com/commercetools/merchant-center-application-kit/blob/main/website/CHANGELOG.md
This change is just to align the bumped versions as I mentioned here: #2754 (comment)
Nothing else changes from the current status quo.
CarlosCortizasCT
left a comment
CarlosCortizasCT
left a comment
There was a problem hiding this comment.
looks very promising 👍
tdeekens
left a comment
tdeekens
left a comment
There was a problem hiding this comment.
This is really nice. Actually been one of my biggest struggles with vhangesets: navigating non aggregated releases in large mono-repos. Thanks for keeping an eye on recent work!
347bb9a to
163ade5
Compare
3 participants
There is an upcoming feature in the changesets/action related to aggregating github releases: changesets/action#193
You can check one of the last comments to see some real world examples.
I think we can give it a try in our next release. For us it should work fine because we're already using fixed versions, so there is one single version for all packages.
The result is having GitHub releases per version as opposed to one GitHub release for each package (as it is now).