-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dualizer, no-recursion, yaya-* #7727
Conversation
Cabal-3.12.0.0 (changelog) is out of bounds for:
QuickCheck-2.15.0.1 (changelog) (Grandfathered dependencies) is out of bounds for:
doctest-0.24.0 (changelog) (Simon Hengel [email protected] @sol) is out of bounds for:
|
@alaendle Thanks – I’m already running builds with updated bounds. Should be published on Hackage soon. @sol I’m not sure what you’re suggesting. I have doctests running via |
@sellout Oh, I see what you’re doing now—very clever! It definitely works, but my point is that you could achieve the same result with just a single shell command, replacing 65 lines of code and configuration. As for compatibility, the documented approach should work with the GHC versions you’re testing in CI. And when it comes to making sure contributors don’t forget to run doctests—well, that’s exactly what CI is for! There’s nothing wrong with your setup, but it’s not the documented approach, and maintaining upper bounds for doctest doesn’t seem like the best use of anyone’s time. Just using the latest version makes things simpler and lets you focus on more interesting problems. |
@sol Thanks – I see what you mean. Thankfully my cabal files are generated, and I really haven’t had to think about doctests (other than writing them). But every line committed to the repo is a liability. I think my original motivation for that approach was for cabal2nix to create derivations that run the doctests, but I think it’s easy enough to get those to run |
Checklist:
add my-cool-package
(please don't mentionbuild-constraints.yml
)cabal update && cabal outdated
)The script runs virtually the following commands in a clean directory: