Skip to content

ci(github-actions): replace env with "with" for docpublish aciton #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 10, 2024

Description

this has been changed since 3.0 as well
peaceiris/actions-gh-pages#123

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@Lee-W
Copy link
Member Author

Lee-W commented Apr 10, 2024

Missed this change in #1058 🤦‍♂️

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (120d514) to head (6bfd02d).
Report is 262 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   97.33%   97.52%   +0.19%     
==========================================
  Files          42       55      +13     
  Lines        2104     2429     +325     
==========================================
+ Hits         2048     2369     +321     
- Misses         56       60       +4     
Flag Coverage Δ
unittests 97.52% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woile woile merged commit c183460 into master Apr 11, 2024
18 checks passed
@woile woile deleted the fix-doc-publish-aciton branch April 11, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants