Skip to content

WIP: implement upgrade_all_documents#84

Draft
tom-tan wants to merge 1 commit into
mainfrom
upgrade-all-docs
Draft

WIP: implement upgrade_all_documents#84
tom-tan wants to merge 1 commit into
mainfrom
upgrade-all-docs

Conversation

@tom-tan

@tom-tan tom-tan commented Nov 14, 2021

Copy link
Copy Markdown
Member

Note: it is not ready to merge!

This request will fixes the issue mentioned in #78.
It contains the following changes:

  • Remove output_dir and imports parameter from upgrade_document not to write any files.
    • It break the functionality of cwl-upgrader command. It is the reason why this request also adds upgrade_all_documents.
  • Add upgrade_all_documents that upgrades all CWL documents in base_dir recursively and writes upgraded CWL documents to output_dir while keeping the directory structure (e.g., basedir/path/to/tool.cwl is upgraded and written into output_dir/path/to/tool.cwl).

Here is a list to make this request ready to merge:

  • implement upgrading imports
  • Add tests
    • process docs in nested directories
    • process imports
  • fix main and run not to break the functionality of cwl-upgrader command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant