Improve environmental variable caching#2101
Merged
mr-c merged 4 commits intocommon-workflow-language:mainfrom Jul 15, 2025
Merged
Improve environmental variable caching#2101mr-c merged 4 commits intocommon-workflow-language:mainfrom
mr-c merged 4 commits intocommon-workflow-language:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
+ Coverage 84.80% 84.86% +0.05%
==========================================
Files 46 46
Lines 8376 8389 +13
Branches 1966 1970 +4
==========================================
+ Hits 7103 7119 +16
+ Misses 806 801 -5
- Partials 467 469 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mr-c
requested changes
Mar 1, 2025
Member
mr-c
left a comment
There was a problem hiding this comment.
Thanks for the extra tests! I see that they motivated some code changes :-)
37aa2ed to
0a2475c
Compare
Example: `tox -e py311-unit -- --lf --pdb`
56ecd43 to
01211da
Compare
Especially with regards to overrides and
`--preserve{-entire,}-environement`
Added more tests for environment variable caching
Co-authored-by: Michael R. Crusoe <mrc@commonwl.org>
…iled, (E)rror; 'fE' is the default
mr-c
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to support environmental variable caching as mentioned here: DataBiosphere/toil#5187 (comment)
The structure of the preserve_environment code is roughly copied from a related function:
cwltool/cwltool/job.py
Lines 486 to 497 in 1b56338