Fix resolve_local returning CWD-anchored URI for commonwl share lookups - #2325
Open
Dev9269 wants to merge 1 commit into
Open
Fix resolve_local returning CWD-anchored URI for commonwl share lookups#2325Dev9269 wants to merge 1 commit into
Dev9269 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2325 +/- ##
==========================================
- Coverage 85.01% 77.55% -7.46%
==========================================
Files 46 46
Lines 8621 8627 +6
Branches 2020 2022 +2
==========================================
- Hits 7329 6691 -638
- Misses 817 1409 +592
- Partials 475 527 +52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_localsearched the XDG_DATA_HOME/commonwl share directories for a tool, found it, but returnedPath(uri).as_uri()— a URI anchored to the current working directory instead of the found file. For relative URIs this raisedValueError: relative path can't be expressed as a file URI; for absolute URIs it pointed at the wrong (nonexistent) file. It also silently dropped#fragmentreferences, and the raw uri (fragments included) was embedded in the share path so fragment lookups never matched.Fix
is_file()instead ofos.path.exists().#fragmentto the result like the direct-file branch does..cwl-extension branch's fragment handling.Tests
New
tests/test_resolver.pywith 3 tests (share lookup, fragment preservation, implicit.cwlextension). All crash/return-wrong-value on the old code.