Add Maven target to format (Java) code using Spotless#41
Add Maven target to format (Java) code using Spotless#41sebastian-nagel merged 5 commits intomainfrom
Conversation
| <setting id="org.eclipse.jdt.core.formatter.comment.indent_parameter_description" value="false"/> | ||
| <setting id="org.eclipse.jdt.core.formatter.number_of_blank_lines_at_beginning_of_code_block" value="0"/> | ||
| <setting id="org.eclipse.jdt.core.formatter.insert_new_line_before_finally_in_try_statement" value="do not insert"/> | ||
| <setting id="org.eclipse.jdt.core.formatter.tabulation.char" value="tab"/> |
There was a problem hiding this comment.
Personally, I prefer spaces rather than tabs.
There was a problem hiding this comment.
Let's not change it because it would cause that the entire code is reformatted.
Tabs is the Eclipse default. One benefit of using only tabs (not mixing tabs and spaces): no need to discuss whether 2 or 4 spaces are the best. You could change the editor view by adjusting the tabulation size without changing the code.
I have no strict preference. And various projects I work with use different indentation styles.
There was a problem hiding this comment.
Those I personally would prefer to have them aligned vertically 🙂
<setting id="org.eclipse.jdt.core.formatter.alignment_for_selector_in_method_invocation" value="80"/>
<setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_method_invocation" value="48"/>
<setting id="org.eclipse.jdt.core.formatter.alignment_for_parameters_in_method_declaration" value="48"/>
There was a problem hiding this comment.
+1 These are useful. Thanks! I'll integrate them, and eventually also update the formatter in cc-webgraph.
Sync the code formatting rules with those defined in commoncrawl/cc-index-table#41.
2 participants
Cf. commoncrawl/cc-webgraph#25.