feat: integrate XRPL #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
k4m4
commented
Mar 5, 2025
k4m4
commented
- Dummy PR to be used for the Axelar team's review.
…Set serialization
…next_verifier_set
…ay is controlled by multisig prover
…ale_weights is needed
…ultisig session ID for prover TX confirmation
style: run clippy & cargo fmt
cjcobb23
reviewed
Mar 5, 2025
|
|
||
| fn next_ticket_number(storage: &dyn Storage) -> Result<u32, ContractError> { | ||
| let last_assigned_ticket_number = LAST_ASSIGNED_TICKET_NUMBER.load(storage)?; | ||
| let available_tickets = AVAILABLE_TICKETS.load(storage)?; |
There was a problem hiding this comment.
this seems a little gas intensive to load all of these tickets from storage every time
maancham
reviewed
Mar 5, 2025
maancham
reviewed
Mar 5, 2025
maancham
reviewed
Mar 5, 2025
maancham
reviewed
Mar 5, 2025
maancham
reviewed
Mar 5, 2025
| } | ||
| } | ||
|
|
||
| impl DustAmount { |
There was a problem hiding this comment.
Wouldn't it be better to avoid the explicit panic! for some functions? It would be better to change this to return a proper Result with a specific error type like the other operations
…ain to enable retries
k4m4
force-pushed
the
xrpl
branch
2 times, most recently
from
7e3ab9a to
d20d974
Compare
…proof construction, & admin rotation
…y_signature, & proof queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.