fix: the description language set to bug by default when uploading image in nearby #6221
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Feb 26, 2025
| @@ -15,7 +16,7 @@ class ResultTuple { | |||
| } | |||
|
|
|||
| constructor() { | |||
| language = "bug" // Basa Ugi language - TODO Respect the `Default description language` setting. | |||
| language = Locale.getDefault().language | |||
There was a problem hiding this comment.
Please use the language configured in Settings>Default description language
Thank you!
There was a problem hiding this comment.
so i am trying to use context to access the sharedpreference and get the "descriptionDefaultLanguagePref" key but i am not able get the context. i tried getting the context in NearbyResultItem class through dependency injection but it was coming null, can you help me with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6191
Removed the hardcoded "bug" string set as the default language when uploading an image in the Nearby feature. Now, the app correctly selects the user's default language instead.
Tests performed (required)
Tested ProdDebug on vivo2334 with API level 35.
Screenshots (for UI changes only)
WhatsApp.Video.2025-02-26.at.15.14.32_b30fbbcf.mp4